[JENKINS-73334] make plugin FIPS-140 compliant by blocking PKCS#12 certificates when in FIPS mode #539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PKCS#12 is not FIPS compliant as such we need to block these certificate uploades when in FIPS mode.
This is expected to be a temporary measure pending JENKINS-73335 as such no tests are introduced for this, rather manual testing was performed.
jtnord
commented
Jun 20, 2024
| <j:set var="keyStoreSourceDescriptors" value="${descriptor.getPropertyType('keyStoreSource').applicableDescriptors}"/> | ||
| <j:choose> | ||
| <j:when test="${keyStoreSourceDescriptors.isEmpty()}"> | ||
| <div class="warning">Jenkins has no <code>KeyStoreSources</code> available, Certificate credentials will not be able to be created.</div> |
There was a problem hiding this comment.
this is a small UI warning as I intend to follow up with https://issues.jenkins.io/browse/JENKINS-73335 so this should not live for that long, hence no tests for this
jtnord
commented
Jun 20, 2024
| @@ -435,6 +436,7 @@ public static class UploadedKeyStoreSource extends KeyStoreSource implements Ser | |||
| @SuppressWarnings("unused") // by stapler | |||
| @Deprecated | |||
| public UploadedKeyStoreSource(String uploadedKeystore) { | |||
| ensureNotRunningInFIPSMode(); | |||
There was a problem hiding this comment.
other plugins are using this code directly, so we can not just not register the extension.
Whilst this will break other plugins, those other plugins are not Compliant and are usign a byte[] that is a PKCS#12 cert - so they are not compliant anyway.
I am not intending to fix /adapt any of these plugins.
olamy
approved these changes
Jun 21, 2024
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JENKINS-73334 Block PKCS#12 certificates due to FIPS-140 compliance issues.
Testing done
manual testing of the form entry in FIPS and non FIPS mode (
mvn clean hpi:run -Djenkins.security.FIPS140.COMPLIANCE=true)screenshots
FIPS mode:
Regular Mode:
Submitter checklist